Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Override CSS margins inherited from Gutenberg. #13146

Conversation

afercia
Copy link
Contributor

@afercia afercia commented Jun 18, 2019

Summary

This PR can be summarized in the following changelog entry:

  • Override CSS rules inherited from Gutenberg that break the Snippet Editor title and description

Test instructions

  • install and activate the Gutenberg plugin, current version: 5.9.2
  • on Yoast SEO trunk, edit a post, go to the metabox and open the snippet editor
  • see the SEO title and description fields display some unexpected spacing, e.g.:

before

  • switch to this branch and build the CSS
  • refresh the page
  • see the SEO title and description fields look as expected, e.g.:

after

Note: a PR has been submitted upstream to better scope the offending CSS selector, see WordPress/gutenberg#16207

Fixes #13145

@IreneStr IreneStr added this to the 11.6 milestone Jun 18, 2019
@dariaknl
Copy link
Contributor

Tested in this feature branch:

  • fixed in metabox

  • still not fixed in sidebar:

Screenshot 2019-06-18 at 13 23 18

@afercia
Copy link
Contributor Author

afercia commented Jun 18, 2019

Latest commit fixes also the snippet editor fields within the modal dialog that opens from the sidebar.

@dariaknl dariaknl merged commit b32b1eb into trunk Jun 18, 2019
@moorscode moorscode deleted the 13145-override-css-inherited-from-gutenberg-breaking-snippet-editor branch June 26, 2019 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Override Gutenberg styles breaking the snippet editor
3 participants