Merge pull request #18187 from Yoast/DUPP-337-fix-overloaded-methods-…

…orm.php

DUPP-337 Use parameter name from ArrayAccess interface in orm.php

lib/orm.php

@@ -2451,50 +2451,50 @@ public function delete_many() {
 	/**
 	 * Checks whether the data has the key.
 	 *
-	 * @param mixed $key Key.
+	 * @param mixed $offset Key.
 	 *
 	 * @return bool Whether the data has the key.
 	 */
 	#[ReturnTypeWillChange]
-	public function offsetExists( $key ) {
-		return \array_key_exists( $key, $this->data );
+	public function offsetExists( $offset ) {
+		return \array_key_exists( $offset, $this->data );
 	}
 
 	/**
 	 * Retrieves the value of the key.
 	 *
-	 * @param mixed $key Key.
+	 * @param mixed $offset Key.
 	 *
 	 * @return array|mixed|null The value.
 	 */
 	#[ReturnTypeWillChange]
-	public function offsetGet( $key ) {
-		return $this->get( $key );
+	public function offsetGet( $offset ) {
+		return $this->get( $offset );
 	}
 
 	/**
 	 * Sets the value of the key.
 	 *
-	 * @param string|int $key   Key.
-	 * @param mixed      $value Value.
+	 * @param string|int $offset Key.
+	 * @param mixed      $value  Value.
 	 */
 	#[ReturnTypeWillChange]
-	public function offsetSet( $key, $value ) {
-		if ( \is_null( $key ) ) {
+	public function offsetSet( $offset, $value ) {
+		if ( \is_null( $offset ) ) {
 			return;
 		}
-		$this->set( $key, $value );
+		$this->set( $offset, $value );
 	}
 
 	/**
 	 * Removes the given key from the data.
 	 *
-	 * @param mixed $key Key.
+	 * @param mixed $offset Key.
 	 */
 	#[ReturnTypeWillChange]
-	public function offsetUnset( $key ) {
-		unset( $this->data[ $key ] );
-		unset( $this->dirty_fields[ $key ] );
+	public function offsetUnset( $offset ) {
+		unset( $this->data[ $offset ] );
+		unset( $this->dirty_fields[ $offset ] );
 	}
 
 	/*