Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changelog: prepare for the release of version 2.0.0 #161

Merged
merged 4 commits into from
Dec 27, 2023

Conversation

enricobattocchi
Copy link
Member

The release date has been tentatively set to next Thursday, December 28, 2023.

@enricobattocchi enricobattocchi added this to the 2.0 milestone Dec 27, 2023
Copy link
Contributor

@jrfnl jrfnl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@enricobattocchi Looks good.

I wonder if the following things should also be mentioned:

CHANGELOG.md Outdated Show resolved Hide resolved
@enricobattocchi
Copy link
Member Author

* That the plugin is now tested up to PHP 8.3.

Right! Pushed.

* PR [132 whip php 81 improvements #133](https://github.com/Yoast/whip/pull/133) - Improved PHP 8.1 compatibility (PRs [Whip_MessageDismisser::verifyNonce(): bug fix #144](https://github.com/Yoast/whip/pull/144) and [Whip_WPMessageDismissListener::listen(): bug fix #145](https://github.com/Yoast/whip/pull/145) are follow ups on this and fix new bugs introduced by [132 whip php 81 improvements #133](https://github.com/Yoast/whip/pull/133), so don't need a explicit mention).

#132 is not actually about PHP 8.1 compatibility I think? We removed the undesirable filter_input occurrences but they weren't actually deprecated since they weren't using any FILTER_SANITIZE_*... so maybe it's not worth mentioning?

* PR [Whip_WPMessagePresenter: remove deprecated method #158](https://github.com/Yoast/whip/pull/158) - Removed method.

Right, pushed.

@jrfnl
Copy link
Contributor

jrfnl commented Dec 27, 2023

#132 is not actually about PHP 8.1 compatibility I think? We removed the undesirable filter_input occurrences but they weren't actually deprecated since they weren't using any FILTER_SANITIZE_*... so maybe it's not worth mentioning?

Well, maybe it is worth mentioning as "security hardening" as no filter was being passed previously, which meant that FILTER_DEFAULT was used, which basically meant that the input was not being sanitized.... ?

@enricobattocchi
Copy link
Member Author

Well, maybe it is worth mentioning as "security hardening" as no filter was being passed previously, which meant that FILTER_DEFAULT was used, which basically meant that the input was not being sanitized.... ?

Makes total sense, pushed

Copy link
Contributor

@jrfnl jrfnl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! :shipit:

@enricobattocchi enricobattocchi merged commit 419e098 into main Dec 27, 2023
@enricobattocchi enricobattocchi deleted the changelog-2.0.0 branch December 27, 2023 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants