Fixes #51 Fixes #55 - Added BasicTilemapTestSuite #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Created BasicTilemapTestSuite, a TestSuite containing 24 facts/testAsyncs that test all the required functionality: tilemap_create_exists_destroy layer_tilemap_get_id tilemap_set_get_mask tilemap_set_get_global_mask tilemap_set_get_tileset tilemap_get_frame tilemap_get_tile_width tilemap_get_tile_height tilemap_set_get_width tilemap_set_get_height tilemap_set_get_x tilemap_set_get_y tilemap_set_get tilemap_set_get_at_pixel tilemap_get_cell_x_at_pixel tilemap_get_cell_y_at_pixel tilemap_clear draw_tilemap tile_set_get_empty tile_set_get_index tile_set_get_flip tile_set_get_mirror tile_set_get_rotate draw_tile Some other resources required for the tests have also been added: tilesAutoAnimated tilesAutoReplacement drawTilemapTestExpected.png drawTilemapTestExpectedBuffer drawTileTestExpected.png drawTileTestExpectedBuffer And a new object to be used with testAsync for testing draw functions was added: objTestAsyncDraw
3 tasks
Indibulous
changed the title
5 tasks
Improved and added comments throughout BasicTilemapTestSuite and objTestAsyncDraw, as well as fixed issues in the tile_set_get_mirror andtilemap_get_frame facts, and removed some redundant code in the tilemap_set_get_global_mask Fact
DiasFranciscoA
requested changes
Jun 18, 2024
The functions start_draw_comparison() and end_draw_comparison() (formerly StartDrawComparison() and EndDrawComparison()) have been moved into a script called draw_test_utils and been modified to use no instance variables, as well as matching the formatting of the other util scripts.
DiasFranciscoA
approved these changes
Jun 19, 2024
DiasFranciscoA
deleted the
51-basictilemaptestsuite-create-new-testsuite-for-testing-tilemap-functionality
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Created BasicTilemapTestSuite, a TestSuite containing 24 facts/testAsyncs that test all the required functionality listed in #51:
Some other resources required for the tests have also been added:
And a new object to be used with testAsync for testing draw functions was added, implementing the functionality described in #55: