Typed library #27
Typed library #27
Conversation
* Configure strict mode for mypy * Add `django-stubs` mypy plugin
|
@Yiling-J don't you mind making the library fully typed? I submitted an example for the Django adapter, please have a look. If it's ok for you, I can fix the typings for the rest of the codebase. |
|
@k0t3n That looks really good! Feel free to add others. |
|
Hi @k0t3n I plan to start refactoring/rewriting to support free-threaded in Python 3.13 (#28). Since this might involve a significant refactor/rewrite, I think it would be better to wait your type improvements and releasing a new version for that. Do you have an estimate for when this will be finished? |
|
@Yiling-J I have almost finished with theine lib, but some work still needs to be done on BWT can we drop support for python 3.7 within these changes? It's not compatible with some stubs and it's EOL finished more than a year ago. |
|
@k0t3n I think it's fine to drop 3.7 support. My concern is that if I make significant changes to |
|
@Yiling-J please have a look and merge if ok for you. I believe we can work on typings for tests/benchmarks later. |
| from theine_core import ClockProCore, LruCore, TlfuCore | ||
| from typing_extensions import ParamSpec, Protocol | ||
|
|
||
| from theine.exceptions import InvalidTTL | ||
| from theine.models import CacheStats | ||
|
|
||
| P = ParamSpec("P") | ||
| R = TypeVar("R", covariant=True, bound=Any) | ||
| R_A = TypeVar("R_A", covariant=True, bound=Union[Awaitable[Any], Callable[..., Any]]) |
There was a problem hiding this comment.
seems R is replaced by R_A? but R_A bound to Union[Awaitable[Any], Callable[..., Any]], so this code
@Memoize(Cache("tlfu", 1000), None)
def foo(id: int, m: Mock) -> Dict[str, int]:
m(id)
return {"id": id}will not pass mypy check. I already tried and this is the error:
error: Value of type variable "R_A" of "__call__" of "Memoize" cannot be "dict[str, int]" [type-var]
|
@k0t3n I think it might be better to add a separate test/example file for all public APIs and have mypy check that file in CI. The actual tests/benchmarks don't need to be typed, as they sometimes need to access internal properties, and typing them could make things more complicated. BTW it seems the |
theinelib