Correct return types for list_secrets, _versions (Azure#7268)

YijunXieMS · Oct 9, 2019 · 1fbfe63 · 1fbfe63
1 parent e96c1d2
commit 1fbfe63
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 2 deletions.
diff --git a/sdk/keyvault/azure-keyvault-secrets/HISTORY.md b/sdk/keyvault/azure-keyvault-secrets/HISTORY.md
@@ -1,4 +1,9 @@
 # Release History
+
+## 4.0.0b4
+### Fixes and improvements
+- `list_secrets` and `list_secret_versions` return the correct type
+
 ## 4.0.0b3 (2019-09-11)
 This release includes only internal changes.
 

diff --git a/sdk/keyvault/azure-keyvault-secrets/azure/keyvault/secrets/client.py b/sdk/keyvault/azure-keyvault-secrets/azure/keyvault/secrets/client.py
@@ -188,7 +188,7 @@ def list_secrets(self, **kwargs):
         return self._client.get_secrets(
             self._vault_url,
             maxresults=max_page_size,
-            cls=lambda objs: [DeletedSecret._from_secret_item(x) for x in objs],
+            cls=lambda objs: [SecretAttributes._from_secret_item(x) for x in objs],
             **kwargs
         )
 
@@ -216,7 +216,7 @@ def list_secret_versions(self, name, **kwargs):
             self._vault_url,
             name,
             maxresults=max_page_size,
-            cls=lambda objs: [DeletedSecret._from_secret_item(x) for x in objs],
+            cls=lambda objs: [SecretAttributes._from_secret_item(x) for x in objs],
             **kwargs
         )