[채팅] redis pub/sub을 활용한 채팅 #93
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Minjae-An
reviewed
May 24, 2024
| private final ObjectMapper objectMapper; | ||
|
|
||
| /** | ||
| * redis pub/sub 메시지 처리 listender 설정 |
There was a problem hiding this comment.
Suggested change
| * redis pub/sub 메시지 처리 listender 설정 | |
| * redis pub/sub 메시지 처리 listener 설정 |
오타 수정 부탁드립니다.
| @@ -39,6 +47,44 @@ public class ChatService { | |||
| private final NotificationQuery notificationQuey; | |||
There was a problem hiding this comment.
Suggested change
| private final NotificationQuery notificationQuey; | |
| private final NotificationQuery notificationQuery; |
이전 PR에서 제대로 리뷰 되지 못한 것 같네요. 죄송합니다. 오타 수정 부탁드립니다.
Comment on lines
14
to
20
| public ChatMessageResponse(long userId, String userName, String content, LocalDateTime sentAt) { | ||
|
|
||
| this.userId = userId; | ||
| this.userName = userName; | ||
| this.content = content; | ||
| this.sentAt = sentAt; | ||
| } |
There was a problem hiding this comment.
@AllArgsConstructor로 간단히 표현할 수 있을 듯 한데, 직접 생성자를 작성하신 이유가 있을까요?
| new ChatMessage(chatRoom, sender, receiver, request.getContent(), request.getSentAt())); | ||
| } | ||
|
|
||
| public List<ChatMessageResponse> getChatMessages(long userId, long roomId) { |
There was a problem hiding this comment.
ChatService의 getChatMessages()와 acceptRequestedChat()의 경우 명시적인 트랜잭션 선언이 안 되어있는데 그 이유가 궁금합니다.
Minjae-An
approved these changes
May 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
작업 대상
📄 작업 내용
🙋🏻 주의 사항