Add ability to send images as links #88
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yentis
requested changes
Dec 28, 2024
| if(contentAfter) { | ||
| args[1].content = contentAfter; | ||
| await callDefault(...args); | ||
| } |
There was a problem hiding this comment.
This will send up to 3 messages for a single user action, which qualifies as self-botting
| if(this.settingsService.settings.sendAsLink) { | ||
| let contentBefore = args[1].content.substring(0, foundEmote.pos); | ||
| let emojiContent = foundEmote.url + `?size=${this.settingsService.settings.emoteSize}`; | ||
| let contentAfter = args[1].content.substring(foundEmote.pos + foundEmote.emoteLength, args[1].content.length); |
There was a problem hiding this comment.
This code doesn't / can't handle emote modifiers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've been using this extension for a long time. I added ability to send images as links at one point, because then it works much quicker and also at some point images that are sent as images are lower quality than images that are sent as links. Here's the comparison between the two:
I usually added changes to the compiled javascript file and decided to finally create a pull request. But I didn't build the project from sources, I only tested it on the compiled javascript file.
As you can see, in my send as link change, I also separate the content before and after from sending the image itself.