sample.py lists all the results found and takes credentials from a co… #283
Conversation
| GRANT_TYPE = 'client_credentials' | ||
|
|
||
|
|
||
| # Defaults for our simple example. | ||
| DEFAULT_TERM = 'dinner' |
There was a problem hiding this comment.
Can we leave the term being a generic search? Makes it more relatable
| CLIENT_SECRET = None | ||
|
|
||
| config = configparser.RawConfigParser() | ||
| config.read('API_Keys.cfg') |
There was a problem hiding this comment.
could you include a default API_Keys.cfg with bogus values?
There was a problem hiding this comment.
Also please don't forget to update it to use an API_KEY rather than CLIENT_ID / CLIENT_SECRET, more details here
| @@ -205,3 +215,6 @@ def main(): | |||
|
|
|||
| if __name__ == '__main__': | |||
| main() | |||
|
|
|||
There was a problem hiding this comment.
The comment below isn't providing much, could you delete it please
| @@ -174,10 +181,13 @@ def query_api(term, location): | |||
| print(u'{0} businesses found, querying business info ' \ | |||
| 'for the top result "{1}" ...'.format( | |||
| len(businesses), business_id)) | |||
| response = get_business(bearer_token, business_id) | |||
There was a problem hiding this comment.
Could you undo the changes to query_api ? This is supposed to be a very basic example program, just printing the top result keeps the example simple and easy to read, adding more complicated logic distracts from the functionality it is trying to highlight
…nfiguration file