You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Let's support at least reading "b3" header from a single string, most commonly traceid-spanid-1
It would also be nice to support optionally writing this, especially in message providers or others with constrained environments.
Brave currently has a property like this, but its name could change with feedback:
/** * When true, only writes a single {@link B3SingleFormat b3 header} for outbound propagation. * * <p>Use this to reduce overhead. Note: normal {@link Tracing#propagation()} is used to parse * incoming headers. The implementation must be able to read "b3" headers. */publicBuilderb3SingleFormat(booleanb3SingleFormat) {
this.b3SingleFormat = b3SingleFormat;
returnthis;
}
The text was updated successfully, but these errors were encountered:
@adriancole How would you handle the transition phase when not all services have been updated to accept the new header?
The client cannot know if the server supports it or not since we don't do any protocol negotiation. Would people need to wait until all their servers have been upgraded before changing the client code?
yes.. server first, just like when we did 128bit trace ID. that is why it
is a bit more urgent to update middleware.. in order to start that
transition.
dual propagation downstream is possible but yeah simpler to start with
making everything understand parsing both.
As discussed on openzipkin/b3-propagation#21 and first implemented here: https://github.com/openzipkin/brave/blob/master/brave/src/main/java/brave/propagation/B3SingleFormat.java https://github.com/openzipkin/brave/blob/master/brave/src/test/java/brave/propagation/B3SingleFormatTest.java
Let's support at least reading "b3" header from a single string, most commonly traceid-spanid-1
It would also be nice to support optionally writing this, especially in message providers or others with constrained environments.
Brave currently has a property like this, but its name could change with feedback:
The text was updated successfully, but these errors were encountered: