Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement "b3 single" header format #98

Open
codefromthecrypt opened this issue Aug 29, 2018 · 2 comments
Open

implement "b3 single" header format #98

codefromthecrypt opened this issue Aug 29, 2018 · 2 comments
Milestone

Comments

@codefromthecrypt
Copy link

As discussed on openzipkin/b3-propagation#21 and first implemented here: https://github.com/openzipkin/brave/blob/master/brave/src/main/java/brave/propagation/B3SingleFormat.java https://github.com/openzipkin/brave/blob/master/brave/src/test/java/brave/propagation/B3SingleFormatTest.java

Let's support at least reading "b3" header from a single string, most commonly traceid-spanid-1
It would also be nice to support optionally writing this, especially in message providers or others with constrained environments.

Brave currently has a property like this, but its name could change with feedback:

    /**
     * When true, only writes a single {@link B3SingleFormat b3 header} for outbound propagation.
     *
     * <p>Use this to reduce overhead. Note: normal {@link Tracing#propagation()} is used to parse
     * incoming headers. The implementation must be able to read "b3" headers.
     */
    public Builder b3SingleFormat(boolean b3SingleFormat) {
      this.b3SingleFormat = b3SingleFormat;
      return this;
}
@drolando
Copy link
Contributor

drolando commented Oct 9, 2018

@adriancole How would you handle the transition phase when not all services have been updated to accept the new header?

The client cannot know if the server supports it or not since we don't do any protocol negotiation. Would people need to wait until all their servers have been upgraded before changing the client code?

@codefromthecrypt
Copy link
Author

codefromthecrypt commented Oct 9, 2018 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants