Introduce auth parameter support in puppet-uchiwa #64
Conversation
|
I think this obsoletes #48 |
|
@solarkennedy I think #61 has already obsoleted #48 |
| @@ -20,7 +20,7 @@ | |||
| "port": <%= @port %>, | |||
| "user": "<%= @user %>", | |||
| "pass": "<%= @pass %>", | |||
| "refresh": <%= @refresh %><%= ',' if @users.size > 0 %> | |||
| "refresh": <%= @refresh %><%= ',' if @users.size > 0 or @auth.size == 2 %> | |||
There was a problem hiding this comment.
This feels strange. I think eventually we need to move to deploying json files directly with ruby instead of writing out an erb
|
@solarkennedy I completely agree with you. Uchiwa has just introduced capability for loading multiple configuration files from a given directory sensu/uchiwa@ff0651b, but the functionality hasn't been released yet. We would also need to adapt the init.d file to provide the functionality and specify a directory to load config files from. Until we get there, unfortunately, we'll have to stick with this horrible puppet template :( Btw, I'm not sure why travis is failing all the tests, I might force a rebuild? |
queeno
force-pushed
the
introduce_static_rsa_keys
branch
from
dc66fb8 to
78a906f
Compare
|
I'm... not sure why the tests started failing. @queeno do they pass locally for you? |
|
Yep it's weird... I raised #65 Apparently Travis wants the gems grouped in All the tests pass locally for this PR. |
|
Got it. Can you merge master? |
|
Yep I will rebase |
This commit introduces the auth paramter, which can be used - starting from uchiwa 0.13.0 in order to specify a static RSA keypair for JWT signature validation.
This commit contains a puppet-rspec test for the newly introduced auth parameter.
queeno
force-pushed
the
introduce_static_rsa_keys
branch
from
78a906f to
c541d0b
Compare
Introduce auth parameter support in puppet-uchiwa
The auth parameter has been introduced in uchiwa 0.13.0 in order to allow the user to specify a static RSA keypair for JWT signature validation.
This PR introduces support for this param in the puppet-uchiwa module.