This repository has been archived by the owner on Feb 4, 2020. It is now read-only.
Avoid puppet to fail when uchiwa::api is not defined and fix JSON indentation issues #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If uchiwa::api is not defined, puppet will fail when parsing the template because @DaTa['api'] is nil. In case this happens, I believe it's appropriate printing out default api config, rather than causing a failure.
The api JSON doesn't indent correctly. This commit fixes the indentation.
|
I like the sane defaults. Can you write a test to ensure this works and will continue to work in the future? |
|
This is now obsolete. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After including puppet-uchiwa in my project, I realised that not defining
uchiwa::apicauses puppet to fail.uchiwa.json.erbexpects@data['api']to contain a hash. However ifuchiwa::apiis not defined,@data['api']will benil.Instead of letting puppet fail, I thought I'd be good practice to include default API configuration parameters in the template.
I've also fixed some JSON indentation issues to make
uchiwa.jsonlook prettier.