Increase vector size limit to 4096 #680
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RP-11388
Lucene has made the max vector dimensions a property of the codec. We override the function to set it to 4096.
There are some risks with bigger vectors - there is a lot of discussion in apache/lucene#11507. These are the most relevant points from the issue:
I thought about not having a limit to allow for easy experimentation, but the above risks are significant. I also considered keeping the limit and make it configurable, but I fear it would effectively be no limit - when needed users will increase it.
I think it's reasonable to still have a limit but increase it to 4096 (same as Elasticsearch). This should allow large enough vector sizes required for experimentation today and not have too much of a risk of performance/correctness/future changes.