Simplify signal handling using sigwait, eliminate some undefined behavior #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🚢 nice |
PhilippWendler
added a commit
to sosy-lab/benchexec
that referenced
this pull request
Oct 17, 2016
Inspired by Yelp/dumb-init#72. In container mode, we need to have a process that acts as PID 1 and forwards all signals to the actual benchmarked process (while at the same time waiting for this process to finish). We can do this with sigwait instead of asynchronous signal handlers, which is less and complex and avoids some signal handling problems.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #58 by processing signals synchronously. It simplifies our code because we don't need to worry about all the special cases that exist for asynchronous signal handlers (there are lots of them).
There shouldn't be any behavior changes here. All existing tests (which are pretty comprehensive) passed, with the exception of the one that tests debug output (since we now report when we get
SIGCHLDas well if running in verbose/debug mode).This also drops the use of
signalwhich @kpengboy pointed out.