-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix exclude_regex functionality (Issue 17) #45
base: master
Are you sure you want to change the base?
Conversation
Thanks so much for making this! 🙏 I will take a look at it this weekend |
(Gonna review after Tavis passes self.add_non_local_repo(mock_rootdir)
> assert not mock_file_operations.write.called
E AssertionError: assert not True
E + where True = <MagicMock name='open().write' id='139948498142936'>.called
E + where <MagicMock name='open().write' id='139948498142936'> = <MagicMock name='open()' id='139948498142488'>.write
tests/actions/initialize_test.py:243: AssertionError
===================== 1 failed, 97 passed in 1.22 seconds ====================== I think) |
Similar test case modification for the empty repo PR #46. Will open a new issue to handle overriding globally because maybe someone wants to not always override? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm 🚢
Thanks so much for making this!
I think there is a merge conflict that needs to be resolve, but that's it.
Looks like this PR pushed us under 93% coverage in Travis:
|
Addresses #17 and #44
Removes
exclude_regex
from tracked repo metadata and config yaml add and replaces with anexclude_files_regex
andexclude_lines_regex
. CLI args are appended to the repo args (but are not overwritten in tracked repo metadata).