Injected headers are casted to strings #288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sjaensch
approved these changes
Jun 12, 2017
|
@macisamuele I think we're converting the header values too soon. We've got internal reports that this change breaks validation for non-string parameters that are passed in the header. I think we need to do the stringifying in bravado-core. |
|
@sjaensch ... that's weird to me ... are we able to reproduce the issue in order to write a test that targets it? |
macisamuele
added a commit
that referenced
this pull request
Jun 22, 2017
…ders Fix regression introduced by PR #288
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As done in bravado-core PR #115 we should cast headers injected via
_request_optionsto string.This is a workaround for requests issue #3491. More context on bravado-core PR