Delete previous plans on autoplan or atlantis plan #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giuli007
requested review from
vikramjakhr,
vulpine,
bobtfish,
filipposc5,
giuliano108,
janpokrzywinski and
technicaljones
janpokrzywinski
approved these changes
Jun 9, 2021
technicaljones
approved these changes
Jun 9, 2021
vikramjakhr
approved these changes
Jun 9, 2021
giuli007
force-pushed
the
delete_potentially_stale_previous_plans
branch
from
b075f74 to
7684d42
Compare
|
Updated to actually not be tiggered when |
janpokrzywinski
approved these changes
Jun 9, 2021
giuli007
force-pushed
the
delete_potentially_stale_previous_plans
branch
2 times, most recently
from
c6cef50 to
250eae4
Compare
When using non-default workspaces, plans are stored in pr-and-workspace-specific directories. If a PR is subsequently updated it might happen that some of the plans are no longer relevant with regards to the latest changes. This change ensures that plans are always deleted when a generic plan is triggered either by autoplan or by a "atlantis plan" command. NB Plans are not cleaned up when specific projects are planned explicitly with "atlantis plan -p/-d/-w".
giuli007
force-pushed
the
delete_potentially_stale_previous_plans
branch
from
250eae4 to
a8a94f9
Compare
|
One more update adding some more unit tests. |
|
I also tried to create a more comprehensive e2e test for this fix as I thought I could reuse some of the code from https://github.com/Yelp/atlantis/blob/master/server/events_controller_e2e_test.go but it turns out those tests are setup to completely mock out how the repositories/workspaces are checked out by atlantis and therefore it is not easy to reproduce the issue that this PR is fixing using the existing test harnesses/mock/stubs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using non-default workspaces, plans are stored in pr-and-workspace-specific directories.
If a PR is subsequently updated it might happen that some of the plans are no longer relevant with regards
to the latest changes.
This change ensures that plans are always deleted when a generic plan is triggered either by autoplan
or by a
atlantis plancommand.NB Plans are not cleaned up when specific projects are planned explicitly with "atlantis plan -p/-d/-w".
The reason for this is better explained in runatlantis#1624 and PEAUTO-1803
This solves the issue and should allow us to re-enable parallel planning
I've tested this locally but will do more testing once this is built as a package