Skip to content

Commit

Permalink
ggml : fix soft max out-of-bounds access (ggerganov#4307)
Browse files Browse the repository at this point in the history
ggml-ci
  • Loading branch information
ggerganov authored Dec 3, 2023
1 parent 33e171d commit adf3de4
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion ggml.c
Original file line number Diff line number Diff line change
Expand Up @@ -15629,7 +15629,6 @@ static int ggml_get_n_tasks(struct ggml_tensor * node, int n_threads) {
} break;
case GGML_OP_DIAG_MASK_ZERO:
case GGML_OP_DIAG_MASK_INF:
case GGML_OP_SOFT_MAX:
case GGML_OP_SOFT_MAX_BACK:
case GGML_OP_ROPE:
case GGML_OP_ROPE_BACK:
Expand All @@ -15645,6 +15644,10 @@ static int ggml_get_n_tasks(struct ggml_tensor * node, int n_threads) {
{
n_tasks = 1; //TODO
} break;
case GGML_OP_SOFT_MAX:
{
n_tasks = MIN(MIN(4, n_threads), ggml_nrows(node->src[0]));
} break;
case GGML_OP_CONV_TRANSPOSE_1D:
{
n_tasks = n_threads;
Expand Down

0 comments on commit adf3de4

Please sign in to comment.