Ros_InformChecker_ValidateJob(..): correct order of arguments when calling mpOpen(..)
#290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Which is how VxWorks open(..) has it (and the M+ API docs). Incorrect order also worked, as `O_RDONLY==0`, but should be corrected nevertheless.
gavanderhoorn
force-pushed
the
inform_checker_mpopen_fix_arg_order
branch
from
a8334d6
to
c79a301
Compare
ted-miller
approved these changes
Aug 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per title.
According to the API documentation:
The incorrect order also worked, as
O_RDONLY==0andmodewas also set to0, but it should be corrected nevertheless.