Skip to content

Commit

Permalink
[protobuf] Load C++,Java,Protobuf rules from Starlark
Browse files Browse the repository at this point in the history
  • Loading branch information
Yannic committed Aug 6, 2019
1 parent a835361 commit 137cc78
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 7 deletions.
8 changes: 4 additions & 4 deletions third_party/protobuf/3.6.1/BUILD
Original file line number Diff line number Diff line change
@@ -1,6 +1,9 @@
# Bazel (http://bazel.io/) BUILD file for Protobuf.

load("@rules_java//java:defs.bzl", "java_import")
load("@rules_cc//cc:defs.bzl", "cc_binary", "cc_library", "cc_test", "objc_library")
load("@rules_java//java:defs.bzl", "java_library")
load("@rules_proto//proto:defs.bzl", "proto_lang_toolchain", "proto_library")
load("@rules_python//python:defs.bzl", "py_library")

licenses(["notice"])

Expand All @@ -24,9 +27,6 @@ config_setting(
load(":protobuf.bzl", "py_proto_library")
load(":compiler_config_setting.bzl", "create_compiler_config_setting")

# Needed for #9006. Hopefully a future upstream version will include this line.
load("@rules_python//python:defs.bzl", "py_library")

filegroup(
name = "srcs",
srcs = glob(
Expand Down
6 changes: 3 additions & 3 deletions third_party/protobuf/3.6.1/protobuf.bzl
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# Needed for #9006. Hopefully a future upstream version will include this line.
load("@rules_cc//cc:defs.bzl", "cc_library")
load("@rules_python//python:defs.bzl", "py_library", "py_test")

def _GetPath(ctx, path):
Expand Down Expand Up @@ -227,7 +227,7 @@ def cc_proto_library(
)

# An empty cc_library to make rule dependency consistent.
native.cc_library(
cc_library(
name = name,
**kargs
)
Expand Down Expand Up @@ -259,7 +259,7 @@ def cc_proto_library(
if use_grpc_plugin:
cc_libs = cc_libs + ["//external:grpc_lib"]

native.cc_library(
cc_library(
name = name,
srcs = gen_srcs,
hdrs = gen_hdrs,
Expand Down
2 changes: 2 additions & 0 deletions third_party/protobuf/3.6.1/util/python/BUILD
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
load("@rules_cc//cc:defs.bzl", "cc_library")

# This is a placeholder for python headers. Projects needing to use
# fast cpp protos in protobuf's python interface should build with
# --define=use_fast_cpp_protos=true, and in addition, provide
Expand Down

0 comments on commit 137cc78

Please sign in to comment.