This repository has been archived by the owner on Oct 30, 2018. It is now read-only.
App fails to boot in nodejitsu #954
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r should be passed when using nodejitsu.
|
+1 |
|
Travis is still unstable. One passed, the other fail :( |
caridy
added a commit
that referenced
this pull request
Jan 26, 2013
Fix for app failures when deploying to nodejitsu.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
App fails to boot in nodejitsu due to a callback wrapper that is synthetically created when calling
app.listen(8080);in server.js. Apparently this callback interrupts the control, and make the app to hang. To solve the problem, we are removing the wrapper in favor of the original callback or nothing, in other words callback argument for app.listen() is optional now.