skip packages that have already been visited #953
Conversation
| @@ -1093,6 +1095,7 @@ YUI.add('mojito-resource-store', function(Y, NAME) { | |||
| this.selectors = {}; | |||
| this._appRVs = []; | |||
| this._mojitRVs = {}; | |||
| this._packagesVisited = {}; | |||
|
|
|||
There was a problem hiding this comment.
Why is _packagesVisited initialized twice?
There was a problem hiding this comment.
It's initialized for every call to preloadResourceVersions(). Internally, preload() calls preloadResourceVersions() twice. The first time is mainly to find RS addons (which can also be found in node_modules). The second time is the "real" load, done once the store has all its addons plugged in. If we didn't clear out packagesVisited then the RS addons wouldn't get a chance to see the resources in the NPM modules.
Said another way, the packages (and app itself) are used to populate _appRVs and _mojitRVs. Anytime we (re)initialized those structures we need to (re)initialize _packagesVisited as well, so that those RV structures can get repopulated.
|
+1 |
skip packages that have already been visited
No description provided.