niri msg pick-window
#1031
Draft
niri msg pick-window
#1031
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbb651
commented
Jan 21, 2025
bbb651
force-pushed
the
niri-msg-pick-window
branch
from
2a2fda5 to
2a25a6d
Compare
WIP: Currently the ipc server gets stuck waiting for niri to return the picked window, and if the ipc client closes it doesn't realize that until niri returns the picked window leading to "ghost" window picking. In general having `self.niri.pick_window.retain(|tx| !tx.is_closed());` to cleanup closed clients in input events feels like the wrong place, but should work since having stale senders doesn't effect anything else. [skip ci]
bbb651
force-pushed
the
niri-msg-pick-window
branch
from
2a25a6d to
368d47d
Compare
|
See commit message:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
recording.mp4
Originally I tried to indicate picking was occurring by turning the cursor into a crosshair, in the same way as the screenshot UI in the seat handler but that means we're forgetting what the original cursor was, I think doing it here will work but still feels a bit hacky, so I removed it for now.
Fixes #589.