Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow using docker secrets for env variables #57

Merged
merged 2 commits into from
Jun 24, 2020
Merged

Allow using docker secrets for env variables #57

merged 2 commits into from
Jun 24, 2020

Conversation

jhollowe
Copy link
Contributor

@jhollowe jhollowe commented Jun 23, 2020 •
edited
Loading

copied in file_env() from the mysql entrypoint and added appropriate calls

not setting defaults, but could modify to set some defaults for the env vars.

closes #52

@jhollowe
Update docker-entrypoint.sh
1b1f514 
copied in file_env() from the mysql entrypoint and added appropriate calls
LeoColomb
LeoColomb requested changes Jun 23, 2020
View reviewed changes
Copy link
Member

@LeoColomb LeoColomb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for your PR, @jhollowe!
It's definitely going in the right direction. 👍

Few remarks as inline comments.

docker-entrypoint.sh Outdated Show resolved Hide resolved
docker-entrypoint.sh Outdated Show resolved Hide resolved
LeoColomb
LeoColomb approved these changes Jun 24, 2020
View reviewed changes
Copy link
Member

@LeoColomb LeoColomb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That looks really good! Thanks again @jhollowe!

@LeoColomb LeoColomb merged commit e0b94b1 into YOURLS:master Jun 24, 2020
docker-library-bot added a commit to docker-library-bot/official-images that referenced this pull request Jun 24, 2020
@docker-library-bot
Update yourls
e4bbcd1 
Changes:

- YOURLS/containers@45b26ce: Update to 1.7.9
- YOURLS/containers@e0b94b1: Allow using docker secrets for env variables (YOURLS/containers#57)
- YOURLS/containers@a8e13b5: Bump actions/checkout from v2.3.0 to v2.3.1
- YOURLS/containers@1ab4077: Bump actions/checkout from v2.2.0 to v2.3.0
- YOURLS/containers@de05e1f: Update dependabot.yml
- YOURLS/containers@06cf288: Bump actions/checkout from v1 to v2.2.0
- YOURLS/containers@e002ec4: Create Dependabot config file
- YOURLS/containers@fe07662: update PHP version and ran update.sh
@cohoe cohoe mentioned this pull request Oct 10, 2020
Closed
3 tasks
@LeoColomb LeoColomb mentioned this pull request Nov 11, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LeoColomb LeoColomb LeoColomb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow using Docker secrets for Environment Variables
2 participants
@jhollowe @LeoColomb