Skip to content

Commit

Permalink
rm checkVersion in tests due to sudo error, renable installing avro p…
Browse files Browse the repository at this point in the history
…lugin
  • Loading branch information
YOU54F committed Feb 27, 2024
1 parent 097a20c commit c0fb9fe
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 9 deletions.
10 changes: 5 additions & 5 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ clean:
mkdir -p ./examples/pacts
rm -rf build output dist examples/pacts

deps:
deps: download_plugins
@echo "--- 🐿 Fetching build dependencies "
cd /tmp; \
go install github.com/mitchellh/gox@latest; \
Expand All @@ -45,10 +45,10 @@ deps:
# go plugin linux-aarch64 version works on musl, requires musl named artifact
# csv plugin requires a musl version creating
# protobuf plugin requires apk add protobuf-dev protoc
# download_plugins:
# @echo "--- 🐿 Installing plugins"; \
# ./scripts/install-cli.sh
# ~/.pact/bin/pact-plugin-cli -y install https://github.com/austek/pact-avro-plugin/releases/tag/v0.0.5
download_plugins:
@echo "--- 🐿 Installing plugins"; \
./scripts/install-cli.sh
~/.pact/bin/pact-plugin-cli -y install https://github.com/austek/pact-avro-plugin/releases/tag/v0.0.5

cli:
@if [ ! -d pact/bin ]; then\
Expand Down
3 changes: 1 addition & 2 deletions examples/protobuf-message/protobuf_provider_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@ import (
"github.com/pact-foundation/pact-go/v2/message"
"github.com/pact-foundation/pact-go/v2/models"
"github.com/pact-foundation/pact-go/v2/provider"
pactversion "github.com/pact-foundation/pact-go/v2/version"
"github.com/stretchr/testify/assert"
)

Expand All @@ -26,7 +25,7 @@ func TestPluginMessageProvider(t *testing.T) {
err := pactlog.SetLogLevel("INFO")
assert.NoError(t, err)

pactversion.CheckVersion()
// pactversion.CheckVersion()

verifier := provider.NewVerifier()

Expand Down
3 changes: 1 addition & 2 deletions examples/provider_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@ import (
"github.com/pact-foundation/pact-go/v2/message"
"github.com/pact-foundation/pact-go/v2/models"
"github.com/pact-foundation/pact-go/v2/provider"
"github.com/pact-foundation/pact-go/v2/version"
"github.com/stretchr/testify/assert"
)

Expand All @@ -28,7 +27,7 @@ var stateHandlerCalled = false

func TestV3HTTPProvider(t *testing.T) {
log.SetLogLevel("INFO")
version.CheckVersion()
// version.CheckVersion()

// Start provider API in the background
go startServer()
Expand Down

0 comments on commit c0fb9fe

Please sign in to comment.