Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove SHIORI3FW.REQUEST_LINES_LIMIT #24

Merged
merged 3 commits into from
Mar 29, 2023

Conversation

steve02081504
Copy link
Member

see https://ukadon.shillest.net/@steve02081504/110100363235728776
I renamed the branch and didn't realise this would cause the #22 to be closed, sorry if it bothered you

Copy link
Member

@nikolat nikolat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with the removal of SHIORI3FW.REQUEST_LINES_LIMIT, as it would be a mistake to make the operation unstable in order to speed up the process.

@steve02081504 steve02081504 changed the title remove SHIORI3FW.REQUEST_LINES_LIMIT remove SHIORI3FW.REQUEST_LINES_LIMIT Mar 28, 2023
@ponapalt ponapalt merged commit 79e9ee9 into master Mar 29, 2023
@nikolat nikolat deleted the remove-SHIORI3FW.REQUEST_LINES_LIMIT branch March 29, 2023 01:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants