Display player names at start of song #920
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For Harmony Vocals, added unique instrument icons for each harmony part
Tweaked position of some elements in VocalPlayerNameDisplay
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a display for the player's name and current instrument that is shown for 3 seconds at the beginning of the song (similar to RB behaviour).
All instruments are supported. For harmony vocalists, each player's harmony part and their needle is displayed as well, making it much easier to see who's singing what.
Solves these feature requests: https://discord.com/channels/1086048856678084609/1301954616065265805
https://discord.com/channels/1086048856678084609/1296184560270446602
Known issue: If a non-vocals part starts empty, the countdown display will obscure the player name display.