Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UPDATE] Converted to namespaces #60

Open
wants to merge 34 commits into
base: master
Choose a base branch
from

Conversation

kersten
Copy link

@kersten kersten commented Jan 20, 2016

Hi @daniellienert ,

this is NOT final!! I only pulled now, because I wanted to let you know that I am working on converting the extension to namespaces.

It would be very helpful if you could check this and tell me where you see some errors.

@daniellienert
Copy link
Member

WHOA! Thanks a lot @kersten!
I will have a look at it as soon as possible.

@kersten
Copy link
Author

kersten commented Jan 20, 2016

thanks. This is still not working, but I would love to see if you could check this in this early state. I've added you as a collaborator so you can use my branch too.

@kersten
Copy link
Author

kersten commented Jan 20, 2016

One more thing. I saw that you are developing Tx_PtExtlist too. There is a class that contains Namespace in it's name. This is not allowed as a namespace so I've renamed it in this commit e4c57a9. I don't know if this is working then. So maybe PtExtlist needs to be changed.

@kersten
Copy link
Author

kersten commented Jan 22, 2016

I have fixed some more errors.

But this one is really strange for me: #1289386765: Could not analyse class: "Tx_Yag_Controller_GalleryController" maybe not loaded or no autoloader?

It happens if I click on Gallery in the left navigation.

There is no Tx_Yag left in the source, all caches are empty, where is this getting from?

Any idea @daniellienert ?

Complete Stacktrace:

#1289386765: Could not analyse class: "Tx_Yag_Controller_GalleryController" maybe not loaded or no autoloader? (More information)

TYPO3\CMS\Extbase\Object\Container\Exception\UnknownObjectException thrown in file
/Users/kersten/Documents/Developing/vendor/typo3/cms/typo3/sysext/extbase/Classes/Object/Container/ClassInfoFactory.php in line 37.

16 TYPO3\CMS\Extbase\Object\Container\ClassInfoFactory::buildClassInfoFromClassName("Tx_Yag_Controller_GalleryController")

/Users/kersten/Documents/Developing/vendor/typo3/cms/typo3/sysext/extbase/Classes/Object/Container/Container.php:
00347:         $classInfo = $this->getClassInfoCache()->get($classNameHash);
00348:         if (!$classInfo instanceof \TYPO3\CMS\Extbase\Object\Container\ClassInfo) {
00349:             $classInfo = $this->getClassInfoFactory()->buildClassInfoFromClassName($className);
00350:             $this->getClassInfoCache()->set($classNameHash, $classInfo);
00351:         }

15 TYPO3\CMS\Extbase\Object\Container\Container::getClassInfo("Tx_Yag_Controller_GalleryController")

/Users/kersten/Documents/Developing/vendor/typo3/cms/typo3/sysext/extbase/Classes/Object/Container/Container.php:
00171:             return $this->singletonInstances[$className];
00172:         }
00173:         $classInfo = $this->getClassInfo($className);
00174:         $classIsSingleton = $classInfo->getIsSingleton();
00175:         if (!$classIsSingleton) {

14 TYPO3\CMS\Extbase\Object\Container\Container::getInstanceInternal("Tx_Yag_Controller_GalleryController", array)

/Users/kersten/Documents/Developing/vendor/typo3/cms/typo3/sysext/extbase/Classes/Object/Container/Container.php:
00124:     {
00125:         $this->prototypeObjectsWhichAreCurrentlyInstanciated = array();
00126:         return $this->getInstanceInternal($className, $givenConstructorArguments);
00127:     }
00128: 

13 TYPO3\CMS\Extbase\Object\Container\Container::getInstance("Tx_Yag_Controller_GalleryController", array)

/Users/kersten/Documents/Developing/vendor/typo3/cms/typo3/sysext/extbase/Classes/Object/ObjectManager.php:
00097:             $instance = call_user_func_array(array(\TYPO3\CMS\Core\Utility\GeneralUtility::class, 'makeInstance'), $arguments);
00098:         } else {
00099:             $instance = $this->objectContainer->getInstance($objectName, $arguments);
00100:         }
00101:         return $instance;

12 TYPO3\CMS\Extbase\Object\ObjectManager::get("Tx_Yag_Controller_GalleryController")

/Users/kersten/Documents/Developing/vendor/typo3/cms/typo3/sysext/extbase/Classes/Mvc/Dispatcher.php:
00113:     {
00114:         $controllerObjectName = $request->getControllerObjectName();
00115:         $controller = $this->objectManager->get($controllerObjectName);
00116:         if (!$controller instanceof \TYPO3\CMS\Extbase\Mvc\Controller\ControllerInterface) {
00117:             throw new \TYPO3\CMS\Extbase\Mvc\Exception\InvalidControllerException('Invalid controller "' . $request->getControllerObjectName() . '". The controller must implement the TYPO3\\CMS\\Extbase\\Mvc\\Controller\\ControllerInterface.', 1202921619);

11 TYPO3\CMS\Extbase\Mvc\Dispatcher::resolveController(TYPO3\CMS\Extbase\Mvc\Web\Request)

/Users/kersten/Documents/Developing/vendor/typo3/cms/typo3/sysext/extbase/Classes/Mvc/Dispatcher.php:
00082:                 throw new \TYPO3\CMS\Extbase\Mvc\Exception\InfiniteLoopException('Could not ultimately dispatch the request after ' . $dispatchLoopCount . ' iterations. Most probably, a @ignorevalidation annotation is missing on re-displaying a form with validation errors.', 1217839467);
00083:             }
00084:             $controller = $this->resolveController($request);
00085:             try {
00086:                 $controller->processRequest($request, $response);

10 TYPO3\CMS\Extbase\Mvc\Dispatcher::dispatch(TYPO3\CMS\Extbase\Mvc\Web\Request, TYPO3\CMS\Extbase\Mvc\Web\Response)

/Users/kersten/Documents/Developing/vendor/typo3/cms/typo3/sysext/extbase/Classes/Mvc/Web/BackendRequestHandler.php:
00030:         /** @var $response \TYPO3\CMS\Extbase\Mvc\ResponseInterface */
00031:         $response = $this->objectManager->get(\TYPO3\CMS\Extbase\Mvc\Web\Response::class);
00032:         $this->dispatcher->dispatch($request, $response);
00033:         return $response;
00034:     }

9 TYPO3\CMS\Extbase\Mvc\Web\BackendRequestHandler::handleRequest()

/Users/kersten/Documents/Developing/vendor/typo3/cms/typo3/sysext/extbase/Classes/Core/Bootstrap.php:
00204:         $requestHandler = $requestHandlerResolver->resolveRequestHandler();
00205: 
00206:         $response = $requestHandler->handleRequest();
00207:         // If response is NULL after handling the request we need to stop
00208:         // This happens for instance, when a USER object was converted to a USER_INT

8 TYPO3\CMS\Extbase\Core\Bootstrap::handleRequest()

/Users/kersten/Documents/Developing/vendor/typo3/cms/typo3/sysext/extbase/Classes/Core/Bootstrap.php:
00191:     {
00192:         $this->initialize($configuration);
00193:         return $this->handleRequest();
00194:     }
00195: 

7 TYPO3\CMS\Extbase\Core\Bootstrap::run("", array)

/Users/kersten/Documents/Developing/vendor/typo3/cms/typo3/sysext/backend/Classes/Http/BackendModuleRequestHandler.php:
00207:             // Run Extbase
00208:             $bootstrap = GeneralUtility::makeInstance(\TYPO3\CMS\Extbase\Core\Bootstrap::class);
00209:             $content = $bootstrap->run('', $configuration);
00210: 
00211:             $response->getBody()->write($content);

6 TYPO3\CMS\Backend\Http\BackendModuleRequestHandler::dispatchModule("web_YagTxYagM1")

/Users/kersten/Documents/Developing/vendor/typo3/cms/typo3/sysext/backend/Classes/Http/BackendModuleRequestHandler.php:
00090:         $moduleName = (string)$this->request->getQueryParams()['M'];
00091:         if ($this->isDispatchedModule($moduleName)) {
00092:             return $this->dispatchModule($moduleName);
00093:         } else {
00094:             // @deprecated: This else path is deprecated and throws deprecations logs at registration time. Can be removed with TYPO3 CMS 8.

5 TYPO3\CMS\Backend\Http\BackendModuleRequestHandler::handleRequest(TYPO3\CMS\Core\Http\ServerRequest)

/Users/kersten/Documents/Developing/vendor/typo3/cms/typo3/sysext/core/Classes/Core/Bootstrap.php:
00300: 
00301:         // Execute the command which returns a Response object or NULL
00302:         $this->response = $requestHandler->handleRequest($request);
00303:         return $this;
00304:     }

4 TYPO3\CMS\Core\Core\Bootstrap::handleRequest(TYPO3\CMS\Core\Http\ServerRequest)

/Users/kersten/Documents/Developing/vendor/typo3/cms/typo3/sysext/backend/Classes/Http/Application.php:
00092:         }
00093: 
00094:         $this->bootstrap->handleRequest($this->request);
00095: 
00096:         if ($execute !== null) {

3 TYPO3\CMS\Backend\Http\Application::run()

/Users/kersten/Documents/Developing/vendor/typo3/cms/typo3/index.php:
00018: call_user_func(function () {
00019:     $classLoader = require __DIR__ . '/../vendor/autoload.php';
00020:     (new \TYPO3\CMS\Backend\Http\Application($classLoader))->run();
00021: });

2 {closure}()
1 call_user_func(Closure)

/Users/kersten/Documents/Developing/vendor/typo3/cms/typo3/index.php:
00019:     $classLoader = require __DIR__ . '/../vendor/autoload.php';
00020:     (new \TYPO3\CMS\Backend\Http\Application($classLoader))->run();
00021: });

@kersten
Copy link
Author

kersten commented Feb 22, 2016

@daniellienert Any chance to get this merged in the next time?

# Conflicts:
#	Classes/Scheduler/Cache/CacheWarmingTaskAdditionalFieldProvider.php
# Conflicts:
#	Classes/Scheduler/Cache/CacheWarmingTaskAdditionalFieldProvider.php
# Conflicts:
#	Classes/Scheduler/Cache/CacheWarmingTaskAdditionalFieldProvider.php
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants