Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce PHP7 warnings according ViewHelper.render declaration. #108

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

kdjkdjkdj
Copy link

No description provided.

@kdjkdjkdj kdjkdjkdj changed the title Merge remote-tracking branch 'refs/remotes/YAG-Gallery/master' please reject [wrong handling of githup workflow] May 7, 2017
@kdjkdjkdj kdjkdjkdj changed the title please reject [wrong handling of githup workflow] please reject [wrong handling of github workflow] May 7, 2017
@kdjkdjkdj kdjkdjkdj changed the title please reject [wrong handling of github workflow] Reduce PHP7 warnings according ViewHelper.render declaration. May 7, 2017
@Kleisli
Copy link

Kleisli commented Oct 26, 2017

@daniellienert Just out of curiosity, if I need a T3 gallery in the future, is this extension still maintained or EOL?

@sigma67
Copy link

sigma67 commented Oct 31, 2018

Hey, I tried your PR and for my setup it yields this error on the initial gallery page:
PHP Fatal error: Class 'Tx_Yag_ViewHelpers_Link_BaseActionViewHelper' not found in /var/www/site/typo3conf/ext/yag/Classes/ViewHelpers/Link/GalleryViewHelper.php on line 32, referer: https://www.site.com/index.php?id=4

I just swapped out the old master version for the pull request version from github. Is there anything else to do to let Typo3 know about the new file?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants