fix https://github.com/sherlock-audit/2023-03-Y2K-judging/issues/72 #127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
3xHarry
commented
Apr 7, 2023
3xHarry
commented
- don't delete Queue item from rollover queue but rather set assets to 0
- add getters
IAm0x52
reviewed
May 5, 2023
src/v2/Carousel/Carousel.sol
Outdated
| // check if user has already queued up a rollover | ||
| if (ownerToRollOverQueueIndex[_receiver] != 0) { | ||
| // if so, update the queue | ||
| if (isEnlistedInRolloverQueue(_receiver)) { |
There was a problem hiding this comment.
Using this will create a new QueueItem for delisted user instead of repopulating (since isEnlistedInRolloverQueue will return false if assets == 0), making it impossible to ever clean them up after
IAm0x52
reviewed
May 5, 2023
|
hey @IAm0x52 i literally run into this issue while testing on test env! THX for catching this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.