CDH/KMS/kbs: read parameters from env

Related to confidential-containers#413. KBS client will also read parameters from env,
including:

- KBC_NAME: The KBC name, i.e. `cc_kbc`, `offline_fs_kbc` or
`online_sev_kbc`
- KBS_URL: The url of KBS
- KBS_PUBLICKEY_CERT: The public key cert of KBS

Signed-off-by: Xynnn007 <[email protected]>

confidential-data-hub/kms/Cargo.toml

@@ -8,7 +8,6 @@ edition = "2021"
 [dependencies]
 anyhow.workspace = true
 async-trait.workspace = true
-attestation_agent = { path = "../../attestation-agent/lib", default-features = false }
 base64.workspace = true
 bincode = { workspace = true, optional = true }
 chrono = { workspace = true, optional = true }

confidential-data-hub/kms/src/error.rs

@@ -3,7 +3,6 @@
 // SPDX-License-Identifier: Apache-2.0
 //
 
-use attestation_agent::aa_kbc_params;
 use thiserror::Error;
 
 pub type Result<T> = std::result::Result<T, Error>;
@@ -23,7 +22,4 @@ pub enum Error {
 
     #[error("Unsupported provider: {0}")]
     UnsupportedProvider(String),
-
-    #[error("aa_kbc_params error")]
-    AaKbcParamsError(#[from] aa_kbc_params::ParamError),
 }

confidential-data-hub/kms/src/plugins/kbs/cc_kbc.rs

@@ -3,12 +3,15 @@
 // SPDX-License-Identifier: Apache-2.0
 //
 
+use std::env;
+
 use async_trait::async_trait;
 use kbs_protocol::{
     client::KbsClient as KbsProtocolClient,
     token_provider::{AATokenProvider, TokenProvider},
     KbsClientCapabilities, ResourceUri,
 };
+use log::{info, warn};
 
 use crate::{Error, Result};
 
@@ -23,12 +26,26 @@ impl CcKbc {
         let token_provider = AATokenProvider::new()
             .await
             .map_err(|e| Error::KbsClientError(format!("create AA token provider failed: {e}")))?;
+
         let client = kbs_protocol::KbsClientBuilder::with_token_provider(
             Box::new(token_provider),
             kbs_host_url,
-        )
-        .build()
-        .map_err(|e| Error::KbsClientError(format!("create kbs client failed: {e}")))?;
+        );
+
+        let client = match env::var("KBS_PUBLICKEY_CERT") {
+            Ok(cert_pem) => {
+                info!("Use KBS public key cert");
+                client.add_kbs_cert(&cert_pem)
+            }
+            Err(e) => {
+                warn!("KBS_PUBLICKEY_CERT get failed: {e:?}. Use no KBS public key certs.");
+                client
+            }
+        };
+
+        let client = client
+            .build()
+            .map_err(|e| Error::KbsClientError(format!("create kbs client failed: {e}")))?;
         Ok(Self { client })
     }
 }

confidential-data-hub/kms/src/plugins/kbs/mod.rs

@@ -16,9 +16,9 @@ mod offline_fs;
 use std::sync::Arc;
 
 use async_trait::async_trait;
-use attestation_agent::aa_kbc_params;
 use lazy_static::lazy_static;
 pub use resource_uri::ResourceUri;
+use std::env;
 use tokio::sync::Mutex;
 
 use crate::{Annotations, Error, Getter, Result};
@@ -33,17 +33,19 @@ enum RealClient {
 
 impl RealClient {
     async fn new() -> Result<Self> {
-        let params = aa_kbc_params::get_params().await?;
+        let kbc = env::var("KBC_NAME")
+            .map_err(|_| Error::KbsClientError("KBC_NAME not set in env".to_string()))?;
+        let _kbs_url = env::var("KBS_URL")
+            .map_err(|_| Error::KbsClientError("KBS_URL not set in env".to_string()))?;
 
-        let c = match params.kbc() {
+        let c = match &kbc[..] {
             #[cfg(feature = "kbs")]
-            "cc_kbc" => RealClient::Cc(cc_kbc::CcKbc::new(params.uri()).await?),
+            "cc_kbc" => RealClient::Cc(cc_kbc::CcKbc::new(&_kbs_url).await?),
             #[cfg(feature = "sev")]
-            "online_sev_kbc" => RealClient::Sev(sev::OnlineSevKbc::new(params.uri()).await?),
+            "online_sev_kbc" => RealClient::Sev(sev::OnlineSevKbc::new(&_kbs_url).await?),
             "offline_fs_kbc" => RealClient::OfflineFs(offline_fs::OfflineFsKbc::new().await?),
             others => return Err(Error::KbsClientError(format!("unknown kbc name {others}, only support `cc_kbc`(feature `kbs`), `online_sev_kbc` (feature `sev`) and `offline_fs_kbc`."))),
         };
-
         Ok(c)
     }
 }

confidential-data-hub/kms/src/plugins/mod.rs

@@ -9,8 +9,6 @@ use strum::{AsRefStr, EnumString};
 
 use crate::{Decrypter, Error, Getter, ProviderSettings, Result};
 
-const _IN_GUEST_DEFAULT_KEY_PATH: &str = "/run/confidential-containers/cdh/kms-credential";
-
 #[cfg(feature = "aliyun")]
 pub mod aliyun;