Migrate asm! to llvm_asm! #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace uses of asm! with llvm_asm!, add the llvm_asm feature [Tracking Issue for LLVM-style inline assembly](rust-lang/rust#70173) `cargo test` now passes for me with rustc 1.45.0-nightly (9310e3bd4 2020-05-21)
|
We'd also need a patch release for this, obviously. This is currently blocking our CI in wgpu. |
|
Thanks! I was so busy to notice this change. will create a path release soon! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace uses of
asm!withllvm_asm!, add thellvm_asmfeatureTracking Issue for LLVM-style inline assembly
cargo testnow passes for me with rustc 1.45.0-nightly (9310e3bd4 2020-05-21)