Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding support for region based XRay APIs #84

Closed
sandeepraina-lenze opened this issue Aug 8, 2024 · 9 comments
Closed

Adding support for region based XRay APIs #84

sandeepraina-lenze opened this issue Aug 8, 2024 · 9 comments
Assignees
Labels
enhancement New feature or request

Comments

@sandeepraina-lenze
Copy link

This is a very helpful plugin. Based on current implementation I want to know how can we extend this plugin for region based XRAY APIs.

e.g. default API URL is https://xray.cloud.getxray.app/
But if I need to access region based XRAY API like https://en.xray.cloud.getxray.app/api/v2/

How can we do it through this plugin.

Please share your insights on this.

@bitcoder
Copy link
Contributor

thanks @sandeepraina-lenze , I will need to research it out; will come back whenever I have feedback

@bitcoder bitcoder added the enhancement New feature or request label Aug 12, 2024
@bitcoder
Copy link
Contributor

The official documentation of Xray Cloud now provides that info.
I'll need to revisit the code on this plugin to provide this feature.
Note that you can still use the https://xray.cloud.getxray.app but it's not the most efficient one.

@bitcoder
Copy link
Contributor

@sandeepraina-lenze can you please try the code on the cloud_region_endpoints branch?
It generates a 0.8.0-beta version. I've update the README file on that branch

@sandeepraina-lenze
Copy link
Author

Hello @bitcoder and thank for your response on this. This was real quick. I will try with the changes in the branch and will share the feedback with you ASAP.

@bitcoder bitcoder self-assigned this Aug 13, 2024
@sandeepraina-lenze
Copy link
Author

Quick question, from which location can I pull this build

@bitcoder
Copy link
Contributor

I have not generated the build. The code is on the branch that I mentioned. You can checkout the code and build it yourself. If you want a jar, I'll need to send it later

@bitcoder
Copy link
Contributor

Here is the package. Install it locally on your local Maven repository and try it out. Unzip it and install it
xray-maven-plugin-0.8.0-beta.jar.zip

@sandeepraina-lenze
Copy link
Author

sandeepraina-lenze commented Aug 14, 2024

Hello @bitcoder

Thank you for the changes, I checked the changes and they work like charm. Will Close the ticket

@sandeepraina-lenze
Copy link
Author

Working as expected

bitcoder added a commit that referenced this issue Aug 14, 2024
…85)

* fixes #84 by adding support to region based Xray Cloud API endpoints

* removed commented code

* bump version to 0.8.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants