Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix aurora software audio decoding #1509

Closed
totaam opened this issue Apr 25, 2017 · 7 comments
Closed

fix aurora software audio decoding #1509

totaam opened this issue Apr 25, 2017 · 7 comments
Labels

Comments

@totaam
Copy link
Collaborator

totaam commented Apr 25, 2017

Issue migrated from trac ticket # 1509

component: sound | priority: major | resolution: fixed

2017-04-25 11:44:34: antoine created the issue


Split from #845. Somewhat related to #1507.

I don't think that this ever worked properly.

Some related fixes and improvements:

If it cannot be fixed, we should remove it.

@totaam
Copy link
Collaborator Author

totaam commented Apr 26, 2017

2017-04-26 07:57:46: antoine changed status from new to assigned

@totaam
Copy link
Collaborator Author

totaam commented Apr 26, 2017

2017-04-26 07:57:46: antoine commented


  • r15717 refactoring
  • r15718 hande end-of-stream, skip empty buffers

@totaam
Copy link
Collaborator Author

totaam commented Apr 28, 2017

2017-04-28 06:01:57: antoine commented


r15732 disables all aurora codecs for trunk - only the builtin wav remains, 15733 does the same for older branches.

I've wasted enough time on this and still can't figure it out.

@totaam
Copy link
Collaborator Author

totaam commented May 1, 2017

2017-05-01 18:05:30: antoine commented


Major related issue fixed in r15783.
This fixes a number of codecs which are now parsed correctly, so r15784 removes them from the blacklist: aac and mp3 via the media source API. (and maybe this should only be done if the server exposes a flag to state that it won't send broken streams since those can crash Safari..)
Sadly, this doesn't fix software decoding via aurora. (so those codecs remain disabled there)

Related: we now handle IE sound using an http stream (r15781 + r15782)

@totaam
Copy link
Collaborator Author

totaam commented Mar 28, 2018

2018-03-28 06:53:30: antoine changed status from assigned to closed

@totaam
Copy link
Collaborator Author

totaam commented Mar 28, 2018

2018-03-28 06:53:30: antoine set resolution to fixed

@totaam
Copy link
Collaborator Author

totaam commented Mar 28, 2018

2018-03-28 06:53:30: antoine commented


Most browsers now support the audio source API, let's deprecate aurora.

@totaam totaam closed this as completed Mar 28, 2018
@totaam totaam added the audio label Jan 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant