html5 client sound forwarding broke

[totaam]

Issue migrated from trac ticket # 1507

component: html5 | priority: major | resolution: fixed

2017-04-23 17:46:45: antoine created the issue

---

Originally reported in #845#comment:28.
Affects trunk and 2.0

[totaam]

2017-04-24 07:41:50: antoine changed status from new to assigned

[totaam]

2017-04-24 07:41:50: antoine commented

---

Bisection:

• r15000 OK
• 15300 BAD
• r15150 OK
• r15225 BAD
• r15190 BAD
• r15170 OK
• r15180 OK
• r15185 BAD
• r15182 OK
• r15184 BAD
• r15183 BAD
• r15182 OK

So that's caused by r15183 which is "#1424: zero copy whenever possible in the network layer".
It's probably sending the wrong datatype down to the audio decoders.

The problems with "legacy:mp3" could just be caused by the lack of mp3 support on the server:

client 3: audio codec mp3 is not supported by the server

(but I thought we had fallback code for this?)

[totaam]

2017-04-24 11:46:43: antoine commented

---

With older versions, the "sound-data" packets contain buffers using the [object Array] datatype, whereas the new code uses Uint8Array.
Oh javascript, why you so flaky.
Fixed in r15697 (will need backporting to v2.0).
Still TODO: fix legacy:mp3?

[totaam]

2017-04-24 18:03:19: antoine commented

---

Found another pair of gems: r15698, r15704 + r15705.

(but I thought we had fallback code for this?)
We do... but it was broken in some cases, fixed in r15701.

Backports for all of the above in: 15706, 15702, 15700.

Minor sound related improvement in r15703.
Then, r15707 improves the buffer handling: we keep the network layer zero-copy buffers until we submit them to the audio decoder. (unlikely to backport this one because it may break something)

[totaam]

2017-04-25 11:48:56: antoine changed status from assigned to new

[totaam]

2017-04-25 11:48:56: antoine changed owner from antoine to afarr

[totaam]

2017-04-25 11:48:56: antoine commented

---

@afarr: mostly a FYI - feel free to close. Sound should now be fixed in 2.0 - and it is also using zero-copy in trunk - the "legacy" decoding issues are now tracked in #1509.

[totaam]

2017-07-20 13:41:37: antoine changed status from new to closed

[totaam]

2017-07-20 13:41:37: antoine set resolution to fixed

[totaam]

2017-07-20 13:41:37: antoine commented

---

crickets - closing.