Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

osx trackpad sends too many events with HTML5 client #1390

Closed
totaam opened this issue Dec 27, 2016 · 5 comments
Closed

osx trackpad sends too many events with HTML5 client #1390

totaam opened this issue Dec 27, 2016 · 5 comments

Comments

@totaam
Copy link
Collaborator

totaam commented Dec 27, 2016

Issue migrated from trac ticket # 1390

component: html5 | priority: major | resolution: fixed

2016-12-27 10:08:12: antoine created the issue


See #1341#comment:15: OSX laptop tracpad events result in dizzyingly & unmanageably fast scrolling (something about the tracpad sending more events with a smaller delta, apparently)

@totaam
Copy link
Collaborator Author

totaam commented Mar 10, 2017

2017-03-10 14:10:02: antoine changed owner from antoine to afarr

@totaam
Copy link
Collaborator Author

totaam commented Mar 10, 2017

2017-03-10 14:10:02: antoine commented


Tablet devices should be handled much better than before.

We normalize the wheel event values using the facebook code found here: normalizeWheel.js : r15253.
And we try to send one event for each javascript wheel event we receive, unless those are very coarse or fine grained (from a tablet?): r15255.

With debug enabled, the Javascript console shows that on Linux I'm getting a delta of 120 per event with Firefox, and ~156 for google chrome..
We'll be able to handle this a lot better once we implement extended input device support (#173)

Links:


@afarr: I don't have the required hardware to test.

@totaam
Copy link
Collaborator Author

totaam commented Jul 20, 2017

2017-07-20 01:51:58: afarr changed status from new to closed

@totaam
Copy link
Collaborator Author

totaam commented Jul 20, 2017

2017-07-20 01:51:58: afarr set resolution to fixed

@totaam
Copy link
Collaborator Author

totaam commented Jul 20, 2017

2017-07-20 01:51:58: afarr commented


Testing against a fedora 25 2.1 16421 server, with OSX 10.12 laptop (with tracpad) using chrome 57 (still running old version in case of need to test some more certs?).

Tracpad behavior is very well handled. Couldn't tell any difference in scrolling handling vs. a mouse with a windows 7 html5 client.

I do notice some tearing/'striping' at times when scrolling though (I know, for another ticket) as well as an issue when I hit a ping timeout and the client reconnected - it ran into 'invalid packet type' error (already made #1586 for this issue).

This one looks good though. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant