Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the icon in the Dock for Mac #505

Merged
merged 2 commits into from
Jan 21, 2023
Merged

Conversation

mgubi
Copy link
Contributor

@mgubi mgubi commented Jan 21, 2023

There is a strange line in texmacs.cpp which reset the icon. I've now fixed it to point to the new icon. I do not understand why this is necessary. I guess we can remove that line since the application icon should be specified in the metadata and not in the code (unless one what to change it programmatically)

@da-liii da-liii merged commit 4af2b95 into XmacsLabs:main Jan 21, 2023
@da-liii da-liii mentioned this pull request Jan 23, 2023
da-liii pushed a commit that referenced this pull request Oct 16, 2023
There is a strange line in `texmacs.cpp` which reset the icon. I've now
fixed it to point to the new icon. I do not understand why this is
necessary. I guess we can remove that line since the application icon
should be specified in the metadata and not in the code (unless one what
to change it programmatically)
da-liii added a commit that referenced this pull request Oct 16, 2023
Related:
+ #504
+ #505

---------

Co-authored-by: mgubi <[email protected]>
github-actions bot pushed a commit that referenced this pull request Oct 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants