[29_3] Modify the way users choose whether to embed tm into pdf #1248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
da-liii
reviewed
Oct 11, 2023
da-liii
reviewed
Oct 11, 2023
| @@ -101,6 +101,29 @@ | |||
| (buffer-close buf)) | |||
| (print-to-file fname))) | |||
|
|
|||
| (tm-define (wrapped-print-to-pdf-embeded-with-tm fname) | |||
There was a problem hiding this comment.
use use-plugin-pdf? to see if pdf plugin is supported
There was a problem hiding this comment.
I think it is better to define here an empty function and then redefine it in the plugin. This is how tm-define is supposed to operate. Alternatively tm-define can be guarded so that the definition is conditional to the presence of the plugin.
mgubi
suggested changes
Oct 14, 2023
| @@ -101,6 +101,29 @@ | |||
| (buffer-close buf)) | |||
| (print-to-file fname))) | |||
|
|
|||
| (tm-define (wrapped-print-to-pdf-embeded-with-tm fname) | |||
There was a problem hiding this comment.
I think it is better to define here an empty function and then redefine it in the plugin. This is how tm-define is supposed to operate. Alternatively tm-define can be guarded so that the definition is conditional to the presence of the plugin.
mgubi
approved these changes
Oct 16, 2023
da-liii
reviewed
Oct 16, 2023
da-liii
reviewed
Oct 16, 2023
| (set-drd cur) | ||
| (dynamic-make-slides) | ||
| (print-to-file fname) | ||
| (unless(attach-doc-to-exported-pdf fname) |
da-liii
reviewed
Oct 16, 2023
da-liii
reviewed
Oct 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before the modification, the option in the preference was used to control whether the exported PDF should be embedded with tm document.
the disadvantage of this method is that it is inconvenient for users.because one would like to leave to the user to choose either to embed or not for each document.
So I deleted the option in preference and added iterm to menu to control whether to embed or not.