[57_3] separate xml to xml and html #1214
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Charonxin
changed the title
|
HTML相关代码需要移动到 src/Plugins/Html 相关目录 |
这个应该属于57_4吗？ |
|
|
|
html有两个cpp文件，移动到 src/Plugins/Html 就可以了吧？ |
|
这里的实现的移动并不是必要的，那就不需要做，保留原样即可，不然找bug的时候，定位问题会很难 |
|
拆分xml和html的关键还是接口 |
|
See #1260 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why you open this Pull Request?
as title
What work have you done in the current Pull Request?