Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

all: update files by 'go generate ./...' #803

Open
wants to merge 1 commit into
base: dev-upgrade
Choose a base branch
from

Conversation

gzliudan
Copy link
Collaborator

@gzliudan gzliudan commented Jan 16, 2025

Proposed changes

This PR updates the files by run go generate ./... except the file eth/tracers/internal/tracers/assets.go.

Types of changes

What types of changes does your code introduce to XDC network?
Put an in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)
  • Regular KTLO or any of the maintaince work. e.g code style
  • CICD Improvement

Impacted Components

Which part of the codebase this PR will touch base on,

Put an in the boxes that apply

  • Consensus
  • Account
  • Network
  • Geth
  • Smart Contract
  • External components
  • Not sure (Please specify below)

Checklist

Put an in the boxes once you have confirmed below actions (or provide reasons on not doing so) that

  • This PR has sufficient test coverage (unit/integration test) OR I have provided reason in the PR description for not having test coverage
  • Provide an end-to-end test plan in the PR description on how to manually test it on the devnet/testnet.
  • Tested the backwards compatibility.
  • Tested with XDC nodes running this version co-exist with those running the previous version.
  • Relevant documentation has been updated as part of this PR
  • N/A

@gzliudan gzliudan force-pushed the go_generate branch 2 times, most recently from cd54cc1 to fe4aa02 Compare January 16, 2025 03:21
@gzliudan gzliudan changed the title all: run go generate all: update files by 'go generate' Jan 16, 2025
@gzliudan gzliudan changed the title all: update files by 'go generate' [WIP] all: update files by 'go generate' Jan 16, 2025
@gzliudan
Copy link
Collaborator Author

TODO: test failure

--- FAIL: TestZeroValueToNotExitCall (0.00s)
    tracers_test.go:153: failed to create call tracer: ReferenceError: identifier 'callTracer' undefined
FAIL
FAIL    github.com/XinFinOrg/XDPoSChain/eth/tracers     0.142s

@wgr523
Copy link
Collaborator

wgr523 commented Jan 19, 2025

TODO: test failure

--- FAIL: TestZeroValueToNotExitCall (0.00s)
    tracers_test.go:153: failed to create call tracer: ReferenceError: identifier 'callTracer' undefined
FAIL
FAIL    github.com/XinFinOrg/XDPoSChain/eth/tracers     0.142s

This file is the cause: eth\tracers\internal\tracers\assets.go. If you checkout the previous commit of this file, the test will pass.

This file was directly updated from a Geth history commit. I did that in PR#558. So I suggest do not change this file.

@gzliudan gzliudan force-pushed the go_generate branch 3 times, most recently from 775c066 to 6004198 Compare January 21, 2025 01:14
@gzliudan gzliudan changed the title [WIP] all: update files by 'go generate' all: update files by 'go generate ./...' Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants