Exp timeout #764
Merged
Exp timeout #764
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
gzliudan
reviewed
Dec 28, 2024
common/countdown/countdown.go
Outdated
| case <-t.resetc: | ||
| log.Debug("Reset countdown timer") | ||
| timer.Reset(t.timeoutDuration) | ||
| timer.Reset(t.durationHelper.GetTimeoutDuration(inputs...)) |
There was a problem hiding this comment.
The timer should be stopped before Reset:
if !timer.Stop() {
<-timer.C
}
timer.Reset(d)
gzliudan
reviewed
Dec 28, 2024
| quitc chan chan struct{} | ||
| initilised bool | ||
| timeoutDuration time.Duration | ||
| lock sync.RWMutex // Protects the Initilised field |
There was a problem hiding this comment.
Can we use atomic.Bool instead of sync.RWMutex ?
gzliudan
reviewed
Dec 28, 2024
common/countdown/exp_duration.go
Outdated
| func (d *ExpTimeoutDuration) sanityCheck() { | ||
| if d.max_exponent >= max_exponent_upperbound { | ||
| log.Error("max_exponent (e)= >= max_exponent_upperbound (e_upper)", "e", d.max_exponent, "e_upper", max_exponent_upperbound) | ||
| panic("max_exponent (e)= >= max_exponent_upperbound (e_upper)") |
There was a problem hiding this comment.
log.Crit can be used here instead of log.Error and panic. But I don't think it's a good idea to call log function in the common package.
|
I notice that |
yes. pushed the changes, please review |
benjamin202410
approved these changes
Jan 7, 2025
benjamin202410
requested changes
Jan 12, 2025
maybe we will do it in another PR |
benjamin202410
approved these changes
Jan 15, 2025
interface. add more inputs as function argument
JukLee0ira
pushed a commit
to JukLee0ira/XDPoSChain
that referenced
this pull request
Jan 20, 2025
* feat: write duration calculation in countdown as interface. add more inputs as function argument * feat: ExpTimeoutDuration * fix: three dots usage * feat: refine exp duration * feat: add exp timeout config and use it in countdown * feat: remove const countdown * feat: remove use of interface in countdown, use error * fix: countdown reset timer problem * fix: add default ExpTimeoutConfig for config
JukLee0ira
pushed a commit
to JukLee0ira/XDPoSChain
that referenced
this pull request
Jan 20, 2025
* feat: write duration calculation in countdown as interface. add more inputs as function argument * feat: ExpTimeoutDuration * fix: three dots usage * feat: refine exp duration * feat: add exp timeout config and use it in countdown * feat: remove const countdown * feat: remove use of interface in countdown, use error * fix: countdown reset timer problem * fix: add default ExpTimeoutConfig for config
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Exp timeout inside consensus timeout countdown
Types of changes
What types of changes does your code introduce to XDC network?
Put an
✅in the boxes that applyImpacted Components
Which part of the codebase this PR will touch base on,
Put an
✅in the boxes that applyChecklist
Put an
✅in the boxes once you have confirmed below actions (or provide reasons on not doing so) that