Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add flag rpc-gascap and set RPCGasCap to 50M #664

Merged
merged 3 commits into from
Oct 9, 2024

Conversation

pro100skm
Copy link

@pro100skm pro100skm commented Oct 8, 2024

Proposed changes

This PR:

  • increase default value of RPCGasCap from 25000000 to 50000000
  • add flag rpc-gascap to set RPCGasCap when startup node

Reference:

Types of changes

What types of changes does your code introduce to XDC network?
Put an in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • [✅] New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)
  • Regular KTLO or any of the maintaince work. e.g code style
  • CICD Improvement

Impacted Components

Which part of the codebase this PR will touch base on,

Put an in the boxes that apply

  • Consensus
  • Account
  • Network
  • [✅] Geth
  • Smart Contract
  • External components
  • Not sure (Please specify below)

Checklist

Put an in the boxes once you have confirmed below actions (or provide reasons on not doing so) that

  • This PR has sufficient test coverage (unit/integration test) OR I have provided reason in the PR description for not having test coverage
  • Provide an end-to-end test plan in the PR description on how to manually test it on the devnet/testnet.
  • Tested the backwards compatibility.
  • [✅] Tested with XDC nodes running this version co-exist with those running the previous version.
  • Relevant documentation has been updated as part of this PR
  • N/A

@gzliudan
Copy link
Collaborator

gzliudan commented Oct 8, 2024

LGTM except lack of introduction.

@gzliudan gzliudan changed the title Gas cap flag add flag rpc-gascap and set RPCGasCap to 50M Oct 9, 2024
@gzliudan gzliudan changed the title add flag rpc-gascap and set RPCGasCap to 50M add flag rpc-gascap and set RPCGasCap to 50M Oct 9, 2024
@gzliudan gzliudan changed the title add flag rpc-gascap and set RPCGasCap to 50M add flag rpc-gascap and set RPCGasCap to 50M Oct 9, 2024
@gzliudan gzliudan merged commit 22c5420 into XinFinOrg:dev-upgrade Oct 9, 2024
17 checks passed
liam-lai pushed a commit that referenced this pull request Oct 9, 2024
@liam-lai liam-lai mentioned this pull request Oct 9, 2024
19 tasks
liam-lai pushed a commit that referenced this pull request Oct 9, 2024
gzliudan pushed a commit that referenced this pull request Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants