Dev upgrade Merge from Auditing Change #418
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix nil Error in function reportBlock
fix timeout too fast issue
Co-authored-by: Liam Lai <[email protected]>
…#18419) The z == 0 check is hit whenever we Add two points with the same x1/x2 coordinate. crypto/elliptic uses the same check in their affineFromJacobian function. This change does not affect block processing or tx signature verification in any way, because it does not use the Add or Double methods.
…ethereum#19609) * Added checks for nil pointers in Marshal functions * Set nil pointer to identity in GT before marshaling
* crypto/cloudflare: fix nil deref in random G1/G2 reading * crypto/bn256: improve fuzzer * crypto/bn256: fix some flaws in fuzzer
When using -buildmode=shared, R15 is clobbered by a global variable access; use a different register instead. Fixes: ethereum#24439
Co-authored-by: Liam Lai <[email protected]>
fix: remove unnecessary assignment
XDC-01 | Potential Missed Fixings in `crypto` Module
fix: update rpc module to include eth fix from ethereum#26064 and ethereum#26723
fix bug and eliminate loop in func PadTo32Bytes
remove key with empty value from map txs in function NewOrderTransactionByNonce
* fix: Make the unused methods in leveldb.go in XDCxDAO to panic or return error if called * fix: apply the same fix in mongodb of the XDCxDAO as well
…e equal in value (#412)
#405) * fix: limit the max size of lending item extradata can be inside the trading and lending transactions * chore: add comment for the MaxLendingExtraDataSize constant
) * RIN-02 Panic Due to Integer Overflow in Signature Size Calculation * assert the error * simply overflow check * simply overflow check --------- Co-authored-by: Liam Lai <[email protected]>
wjrjerome
requested review from
wjrjerome,
wgr523,
AnilChinchawale and
wanwiset25
wjrjerome
approved these changes
Feb 5, 2024
Co-authored-by: wjrjerome <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Merge all the auditing change and deployment improvement.
fea90a9 (HEAD -> dev-upgrade, origin/dev-upgrade) RIN-02 Panic Due to Integer Overflow in Signature Size Calculation (#401)
95e108c fix: limit the max size of lending item extradata can be inside the t… (#405)
b4d842b chore: remove unnecessary order.status assignment (#407)
976dd79 chore: remove redunant nil check (#408)
326a8c8 fix: Fix Potential Index Out of Bound (#409)
0664e9f chore: remove the unused false return value from GetCollaterals method (#410)
d70c156 chore: remove the unused method in ringct.go (#411)
cac03bd fix: GenNewKeyRing should return out of bound error if s and ring size equal in value (#412)
743fc85 chore: return statement optimization (#406)
a3c392c Fix xdcx infinite recursive calls (#404)
2504961 fix: replace all time.after with the time.newtimer (#400)
0d7dd86 Merge pull request #402 from gzliudan/XDP-02
7403063 Merge pull request #403 from gzliudan/fix-func-PadTo32Bytes
ffa38cd fix bug and eliminate loop in func PadTo32Bytes
e097f2b remove key with empty value from map txs in func NewOrderTransactionByNonce
559bb4f Merge pull request #394 from XinFinOrg/xds-01-fixing-rpc-module
513114d Merge pull request #398 from XinFinOrg/XDC-01
ddac0a6 Merge pull request #399 from XinFinOrg/xdp-01
71c4425 chore: log the error object
786e379 (origin/xdp-01) fix: remove unnecessary assignment
7f02151 (origin/xds-01-fixing-rpc-module) fix: update rpc module to include eth fix from ethereum#26064 and ethereum#26723
9bb8c8c XDP-03 (#396)
aaa246f PDF-01 (#397)
81ff642 fix Panic In ProcessOrderPending Leads To Chain Halt (#392)
d4b9806 (origin/XDC-01) crypto/bn256/cloudflare: fix asm for dynamic linking (ethereum#24476)
af8c4d4 crypto/cloudflare/bn256: fix in-place addition and unmarshalling (ethereum#23419)
3a6e26b crypto/bn256: improve bn256 fuzzer (ethereum#21815)
c48e987 crypto/bn256/cloudflare: checks for nil pointers in Marshal functions (ethereum#19609)
3d635c5 crypto/secp256k1: add checking z sign in affineFromJacobian (ethereum#18419)
a76c885 devnet deployment issue (#395)
c36df9f Merge pull request #393 from XinFinOrg/fix-timeout-too-fast
3e6ce89 (origin/fix-timeout-too-fast, fix-timeout-too-fast) fix timeout too fast issue
d24f187 Host rpc node in ecs (#391)
3225467 Merge pull request #370 from gzliudan/fix-issue-369
ded4e0f fix nil Error in func reportBlock (#369)
Types of changes
What types of changes does your code introduce to XDC network?
Put an
✅in the boxes that applyImpacted Components
Which part of the codebase this PR will touch base on,
Put an
✅in the boxes that applyChecklist
Put an
✅in the boxes once you have confirmed below actions (or provide reasons on not doing so) that