Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TorchToTosa: attempt to fold tosa::add in AtenBroadcastToOp legalization. #94

Merged

Conversation

ttjost
Copy link

@ttjost ttjost commented Jun 14, 2023

No description provided.

@ttjost ttjost requested a review from mgehre-amd June 14, 2023 11:29
@mgehre-amd
Copy link
Collaborator

Curious, why was this change necessary for your story? Or is this a drive-by fix?

@ttjost
Copy link
Author

ttjost commented Jun 14, 2023

Curious, why was this change necessary for your story? Or is this a drive-by fix?

For the model we are testing, repeat.interleave uses the broadcast_to operation as the repeat operand of the operation. It turns out that we cannot work with the add created by the broadcast_tolegalization, but the operation can be folded to a constant. It is only then that we are able to legalizerepeat_interleave. Unfortunately, I don't think we can go much further than that for the repeat_interleave` story, meaning, things have to be constant foldable.

@mgehre-amd mgehre-amd closed this Jun 14, 2023
@mgehre-amd mgehre-amd reopened this Jun 14, 2023
@mgehre-amd mgehre-amd enabled auto-merge (squash) June 14, 2023 12:36
@mgehre-amd mgehre-amd merged commit 0a19469 into feature/misc_fixes Jun 14, 2023
@mgehre-amd mgehre-amd deleted the tiagot.fold_add_broadcastto_legalization branch June 14, 2023 13:10
@mgehre-amd mgehre-amd mentioned this pull request Jun 16, 2023
51 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants