Support for tosa.custom_op operations. #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgehre-amd
reviewed
Jun 1, 2023
mgehre-amd
reviewed
Jun 1, 2023
mgehre-amd
approved these changes
Jun 1, 2023
ljfitz
approved these changes
Jun 1, 2023
ttjost
force-pushed
the
tiagot.custom_op_support
branch
from
f94c1d1
to
8856e70
Compare
ttjost
force-pushed
the
tiagot.custom_op_support
branch
from
8856e70
to
96caf37
Compare
cmcgirr-amd
approved these changes
Jun 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding all of you so that you are aware of this in case we need to implement a
tosa.custom_opfor other unsupported operations.This will lower a tosa unsupported operation to something like:
"tosa.custom"(%arg0, %arg1) <{config = "UNDEF", identifier = "atan2", implementation_attrs = "UNDEF"}> : (tensor<?x?xf32>, tensor<?x?xf32>) -> tensor<?x?xf32>We are mostly interest in the
identifierattribute. Other could be set later if necessary, but I don't think we need them for now.The PR includes an LLVM bump, but I'll make sure to update it again once the PR in the
llvm-projectis approved.