Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support prims.sum / torch.cumsum #50

Merged
merged 7 commits into from
May 31, 2023
Merged

Support prims.sum / torch.cumsum #50

merged 7 commits into from
May 31, 2023

Conversation

mgehre-amd
Copy link
Collaborator

@mgehre-amd mgehre-amd commented May 30, 2023 •
edited
Loading

  • Decompose aten.cumsum into prims.sum
  • Support prims.sum in torch IR
  • Decompose prims.sum into aten.sum because backends already support aten.sum

@mgehre-amd mgehre-amd requested a review from ljfitz May 30, 2023 20:39
@mgehre-amd mgehre-amd enabled auto-merge (squash) May 30, 2023 21:38
ljfitz
ljfitz approved these changes May 31, 2023
View reviewed changes
Copy link
Collaborator

@ljfitz ljfitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (and so annoyed I didn't think of checking if we needed the troublesome output_dtype support).

python/torch_mlir/dialects/torch/importer/jit_ir/build_tools/abstract_interp_lib_gen.py Show resolved Hide resolved
@mgehre-amd mgehre-amd merged commit 97503d6 into feature/misc_fixes May 31, 2023
@mgehre-amd mgehre-amd deleted the matthias.cumsum branch May 31, 2023 11:49
@mgehre-amd mgehre-amd mentioned this pull request Jun 5, 2023
Open
51 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ljfitz ljfitz ljfitz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mgehre-amd @ljfitz