lib/Dialect/Torch/IR/TorchOps.cpp: Canonicalize rank changing broadcast_to into reshape + broadcast_to #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgehre-amd
force-pushed
the
matthias.broad_cast_rank
branch
from
8a2235e
to
c729792
Compare
…st_to into reshape + broadcast_to
mgehre-amd
force-pushed
the
matthias.broad_cast_rank
branch
from
c729792
to
afb23d9
Compare
ttjost
reviewed
May 30, 2023
flemairen6
approved these changes
May 30, 2023
ljfitz
approved these changes
May 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The aten.broadcast_to op both does broadcasting but can also increase the rank by adding dimensions with size 1.
The torch->tosa lowering only handles broadcast_to that are not increasing the rank. To also help other backends, I added a canonicalizer for broadcast_to that splits into into a reshape and a non-rank changing broadcast_to.