Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RecomposeComplexOps: Don't call erase after replaceOpWithNewOp #111

Merged
merged 1 commit into from
Jun 21, 2023
Merged

RecomposeComplexOps: Don't call erase after replaceOpWithNewOp #111

merged 1 commit into from
Jun 21, 2023

Conversation

mgehre-amd
Copy link
Collaborator

No description provided.

@mgehre-amd mgehre-amd requested a review from ttjost June 21, 2023 13:09
ttjost
ttjost approved these changes Jun 21, 2023
View reviewed changes
Copy link

@ttjost ttjost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh well, better to let CSE or DCE take care of optimizing it. Thanks for the fix!

@mgehre-amd mgehre-amd merged commit 42de546 into feature/misc_fixes Jun 21, 2023
@mgehre-amd mgehre-amd deleted the matthias.fix_double_erase branch June 21, 2023 13:47
@mgehre-amd mgehre-amd mentioned this pull request Jun 21, 2023
Open
51 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ttjost ttjost ttjost approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mgehre-amd @ttjost