Fix to threshold's width optimization #866
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The width of the thresholds are based on the width of the input datatype and threshold datatype. The input datatype is in most cases coming from an
MVU, which will have by default a 32-bit output datatype. Since theMinimizeAccumulatorWidthis applied iteratively in a loop, the output datatype of theMVUis optimized/minimized before theThresholding_Batchlayer is considered. However, we need to run theInferDataTypestransformation to propagate this information such that the succeedingThresholding_Batchknows of the minimized bit-width of the input (and does not default to 32-bit thresholds).