hls::vector interface for DuplicateStreams #141
Conversation
streamtools.h
Outdated
| T e = in.read(); | ||
| out1.write(e); | ||
| out2.write(e); | ||
| } |
There was a problem hiding this comment.
Please, undo mere indentation changes.
streamtools.h
Outdated
| template<typename T, unsigned int NumTotal > | ||
| void DuplicateStreams_Batch(hls::stream<T> & in, hls::stream<T> & out1, | ||
| hls::stream<T> & out2, const unsigned int numReps) { | ||
| for (unsigned int image = 0; image < numReps; image++) { |
There was a problem hiding this comment.
Please, don't just change indentation.
tb/data/dup_stream_config.h
Outdated
| using T = ap_uint<8>; | ||
| constexpr unsigned NUM_REPEAT = 4; |
There was a problem hiding this comment.
Please, fix missing end of line.
tb/dup_stream_tb.cpp
Outdated
| stream<T> output_stream1("output_stream"); | ||
| stream<T> output_stream2("output_stream"); | ||
| static T expected[NUM_REPEAT*MAX_IMAGES]; | ||
| unsigned int count_out = 0; |
There was a problem hiding this comment.
Again, many lines are just indentation changes. Please, undo.
| @@ -2,10 +2,15 @@ | |||
| using namespace hls; | |||
| #include "ap_int.h" | |||
| #include "bnn-library.h" | |||
There was a problem hiding this comment.
It looks like you could reduce these includes to hls_stream.h only. Please, do if possible.
tb/dup_stream_top.cpp
Outdated
| void Testbench_dup_stream(stream<ap_uint<WIDTH> > & in, stream<ap_uint<WIDTH> > & out1, stream<ap_uint<WIDTH> > & out2, unsigned int numReps){ | ||
| DuplicateStreams_Batch<WIDTH, NUM_REPEAT>(in, out1, out2, numReps); | ||
| } | ||
| void Testbench_dup_stream(stream<T> & in, stream<T> & out1, stream<T> & out2, unsigned int numReps){ |
There was a problem hiding this comment.
As a consequence of the above, please, use hls::stream rather than stream.
|
Hi @preusser, |
|
THanks, @vopade! This looks good. Getting ready for the merge ... |
|
Commit for pooling operators was automatically added to this PR since it was still open. Please review @preusser |
Changed interfaces of
DuplicateStreamsandDuplicateStreams_Batchas well as pooling operators from packed to hls::vector